From 8254c1686e4eec50f9ef4836d1cb742e7caf54a1 Mon Sep 17 00:00:00 2001 From: savvasha Date: Sat, 25 Jul 2020 20:14:21 +0300 Subject: [PATCH] Avoid filtering if League AND Season arrays are empty It makes more sense. That way you can filter a Player List by League and Team, or by Season and Team. Otherwise you have false positives! --- modules/sportspress-player-assignments.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/sportspress-player-assignments.php b/modules/sportspress-player-assignments.php index 5113008c..c25f2b52 100644 --- a/modules/sportspress-player-assignments.php +++ b/modules/sportspress-player-assignments.php @@ -78,7 +78,7 @@ class SportsPress_Player_Assignments { if ( 'sp_season' === sp_array_value( $param, 'taxonomy' ) ) $season_ids = sp_array_value( $param, 'terms', array() ); } - if ( empty( $league_ids ) || empty( $season_ids ) ) return $args; + if ( empty( $league_ids ) && empty( $season_ids ) ) return $args; $args['meta_query'][] = array( 'key' => 'sp_assignments',