asc/sportspress
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

We should not be escaping when we build a variable, but when we output it at the end. We call this 'escaping late.'

Browse Source
This commit is contained in:
Savvas Hadjigeorgiou
2021-11-05 13:42:23 +02:00
parent 8074b59639
commit 82dc48317c
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
includes/admin/class-sp-admin-settings.php
View File

@@ -252,11 +252,11 @@ class SP_Admin_Settings {
if ( $tip && in_array( $value['type'], array( 'checkbox' ) ) ) {
$tip = '<p class="description">' . esc_attr( $tip ) . '</p>';
$tip = '<p class="description">' . $tip . '</p>';
} elseif ( $tip ) {
$tip = '<i class="dashicons dashicons-editor-help sp-desc-tip" title="' . esc_attr( $tip ) . '" />';
$tip = '<i class="dashicons dashicons-editor-help sp-desc-tip" title="' . $tip . '" />';
}