From ab1ab5ba6122347ac2891f58e1ee0f81b374a427 Mon Sep 17 00:00:00 2001
From: Brian Miyaji <brian@themeboy.com>
Date: Thu, 18 Nov 2021 21:39:44 +0900
Subject: [PATCH] Fix dropdown options not saving in settings

---
 includes/admin/class-sp-admin-settings.php | 23 ++++------------------
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/includes/admin/class-sp-admin-settings.php b/includes/admin/class-sp-admin-settings.php
index 1c522638..45eca358 100644
--- a/includes/admin/class-sp-admin-settings.php
+++ b/includes/admin/class-sp-admin-settings.php
@@ -404,12 +404,7 @@ if ( ! class_exists( 'SP_Admin_Settings' ) ) :
 						</th>
 						<td class="forminp forminp-<?php echo esc_attr( $value['type'] ); ?>">
 							<select
-								name="<?php echo esc_attr( $value['id'] ); ?>
-												 <?php
-													if ( $value['type'] == 'multiselect' ) {
-														echo '[]';}
-													?>
-								"
+								name="<?php echo esc_attr( $value['id'] ); ?><?php if ( $value['type'] == 'multiselect' ) { echo '[]';} ?>"
 								id="<?php echo esc_attr( $value['id'] ); ?>"
 								style="<?php echo esc_attr( $value['css'] ); ?>"
 								class="chosen-select
@@ -458,12 +453,7 @@ if ( ! class_exists( 'SP_Admin_Settings' ) ) :
 						</th>
 						<td class="forminp forminp-<?php echo esc_attr( $value['type'] ); ?>">
 							<select
-								name="<?php echo esc_attr( $value['id'] ); ?>
-												 <?php
-													if ( $value['type'] == 'multiselect' ) {
-														echo '[]';}
-													?>
-								"
+								name="<?php echo esc_attr( $value['id'] ); ?><?php if ( $value['type'] == 'multiselect' ) { echo '[]';} ?>"
 								id="<?php echo esc_attr( $value['id'] ); ?>"
 								style="<?php echo esc_attr( $value['css'] ); ?>"
 								class="chosen-select
@@ -526,12 +516,7 @@ if ( ! class_exists( 'SP_Admin_Settings' ) ) :
 						</th>
 						<td class="forminp forminp-<?php echo esc_attr( $value['type'] ); ?>">
 							<select
-								name="<?php echo esc_attr( $value['id'] ); ?>
-												 <?php
-													if ( $value['type'] == 'multiselect' ) {
-														echo '[]';}
-													?>
-								"
+								name="<?php echo esc_attr( $value['id'] ); ?><?php if ( $value['type'] == 'multiselect' ) { echo '[]';} ?>"
 								id="<?php echo esc_attr( $value['id'] ); ?>"
 								style="<?php echo esc_attr( $value['css'] ); ?>"
 								class="sp-select-sport chosen-select
@@ -718,7 +703,7 @@ if ( ! class_exists( 'SP_Admin_Settings' ) ) :
 					continue;
 				}
 
-				$type = isset( $value['type'] ) ? esc_attr( $value['type'] ) : '';
+				$type = isset( $value['type'] ) ? sanitize_key( $value['type'] ) : '';
 
 				// Get the option name
 				$option_value = null;