From 987a266cb25ba0028093d6418ce7ba3fb4632b6a Mon Sep 17 00:00:00 2001 From: Nabil Kadimi Date: Tue, 8 May 2018 15:00:49 +0100 Subject: [PATCH 1/2] Make sure $leagues is an array of non-empty values --- templates/player-statistics.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/player-statistics.php b/templates/player-statistics.php index f7ed0463..8ac44698 100644 --- a/templates/player-statistics.php +++ b/templates/player-statistics.php @@ -19,7 +19,7 @@ $scrollable = get_option( 'sportspress_enable_scrollable_tables', 'yes' ) == 'ye $show_career_totals = 'yes' === get_option( 'sportspress_player_show_career_total', 'no' ) ? true : false; $sections = get_option( 'sportspress_player_performance_sections', -1 ); $show_teams = apply_filters( 'sportspress_player_team_statistics', true ); -$leagues = get_the_terms( $id, 'sp_league' ); +$leagues = array_filter( ( array ) get_the_terms( $id, 'sp_league' ) ); // Sort Leagues by User Defined Order (PHP5.2 supported) foreach ( $leagues as $key => $league ) { From daa77c70e06633c75f32b1fc604e5981ddf85117 Mon Sep 17 00:00:00 2001 From: Nabil Kadimi Date: Tue, 8 May 2018 15:07:11 +0100 Subject: [PATCH 2/2] Make sure $leagues/$season_ids are array of non-empty --- includes/class-sp-player.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/class-sp-player.php b/includes/class-sp-player.php index fc54d9b5..0b671e30 100644 --- a/includes/class-sp-player.php +++ b/includes/class-sp-player.php @@ -126,10 +126,10 @@ class SP_Player extends SP_Custom_Post { $seasons = (array)get_the_terms( $this->ID, 'sp_season', $args ); $metrics = (array)get_post_meta( $this->ID, 'sp_metrics', true ); $stats = (array)get_post_meta( $this->ID, 'sp_statistics', true ); - $leagues = sp_array_value( (array)get_post_meta( $this->ID, 'sp_leagues', true ), $league_id, array() ); + $leagues = (array) sp_array_value( (array)get_post_meta( $this->ID, 'sp_leagues', true ), $league_id ); $manual_columns = 'manual' == get_option( 'sportspress_player_columns', 'auto' ) ? true : false; - $season_ids = wp_list_pluck( $seasons, 'term_id' ); + $season_ids = array_filter(wp_list_pluck( $seasons, 'term_id' )); $season_order = array_flip( $season_ids ); foreach ( $season_order as $season_id => $val ) { $season_order[ $season_id ] = null;